Author Archives: chrismay

VS.Net Macro to Narrow VB.Net Method Signatures and Function Calls

Posted on by

Lately I have been doing some refactoring of code as I go through it.

Trying to name variables correctly, breaking up long methods, trying to adhere to some coding standards.

One way that I have been employing to clean up code is to convert very long method signatures, or calls to methods with many parameters from LONG single line entities to shorter multi-line blocks.

This is simple, but tedious.  So I wrote a VS.Net macro to do it for me.

Simply copy and paste the macro code (paste into wordpad first to get rid of the missing newline problem) at the bottom of this article into a macro.  Then all you have to do is highlight the entire row you want to “narrow”, and run the macro.  You can always Cntl+z out of it if you want to undo the changes.

The results are good!  The following are examples of a long method signature, and a call to a method with a lot of arguments, and then the refactored results.

'*** Long method signature
Public Function ActivitySave(ByVal Activity As MyNamespace.Business.Equipment.Activity, ByVal StartTime As DateTime, ByVal EndTime As DateTime, ByVal StatusOverride As System.Nullable(Of MyNamespace.Business.Data.Criteria.Equipment.ActivityStatusEnum), ByVal Clerk As Integer) As Integer

'*** long method call
ActivityID = MainActivity.ActivitySave(Activity.ActivityID, Activity.Status, Activity.PurposeNotes, Activity.JobIndex, Activity.CategoryID, Activity.RequestedStartDate, Activity.RequestedEndDate, Activity.EquipmentID, Activity.PlanStartDate, Activity.PlanEndDate, Activity.ActualStartDate, Activity.ActualEndDate, Activity.DiscountScheduleID, Activity.DiscountOffset, Activity.CodeID, Activity.RentalRate, Activity.RowVersion, Clerk)

Here is the result of the refactoring:

'*** Refactored long method signature
Public Function ActivitySave(ByVal Activity As MyNamespace.Business.Equipment.Activity, _
                             ByVal StartTime As DateTime, _
                             ByVal EndTime As DateTime, _
                             ByVal StatusOverride As System.Nullable(Of MyNamespace.Business.Data.Criteria.Equipment.ActivityStatusEnum), _
                             ByVal Clerk As Integer) As Integer

'*** Refactored long call
ActivityID = MainActivity.ActivitySave(Activity.ActivityID, _
                                       Activity.Status, _
                                       Activity.PurposeNotes, _
                                       Activity.JobIndex, _
                                       Activity.CategoryID, _
                                       Activity.RequestedStartDate, _
                                       Activity.RequestedEndDate, _
                                       Activity.EquipmentID, _
                                       Activity.PlanStartDate, _
                                       Activity.PlanEndDate, _
                                       Activity.ActualStartDate, _
                                       Activity.ActualEndDate, _
                                       Activity.DiscountScheduleID, _
                                       Activity.DiscountOffset, _
                                       Activity.CodeID, _
                                       Activity.RentalRate, _
                                       Activity.RowVersion, _
                                       Clerk)

 

Here is the macro.

 Public Sub NarrowMethodsAndCalls()
        'Create an Undo context object so all the changes can be
        'undone by CTRL+Z
        Dim oUnDo As UndoContext = DTE.UndoContext

        'Supress the User Interface. This will make it run faster
        'and make all the changes appear once
        DTE.SuppressUI = True
        Try


            Dim oTextSelection As TextSelection = DTE.ActiveWindow.Selection
            Dim sOrigText As String = oTextSelection.Text

            Dim RegExp As New System.Text.RegularExpressions.Regex("([ .=_a-zA-Z0-9]*)(")
            Dim Match As System.Text.RegularExpressions.Match = RegExp.Match(sOrigText)
            If Match.Success Then
                Dim sMethod As String = Match.ToString
                Dim sParametersAndReturn() As String = sOrigText.Replace(sMethod, "").Split(",")
                Dim sFirstLineWhiteSpace As String
                Dim sb As New System.Text.StringBuilder
                sb.Append(" ", Trim(sMethod).Length)
                sFirstLineWhiteSpace = sb.ToString

                '*** redo the first line
                oTextSelection.Text = sMethod & sParametersAndReturn(0) & ", _"
                oTextSelection.NewLine()
                oTextSelection.Text = sFirstLineWhiteSpace

                For i As Integer = 1 To sParametersAndReturn.Length - 2
                    oTextSelection.Text = Trim(sParametersAndReturn(i)) & ", _"
                    oTextSelection.NewLine()
                Next
                oTextSelection.Text = Trim(sParametersAndReturn(sParametersAndReturn.Length - 1))
                oTextSelection.NewLine()



            Else
                MsgBox("failed to find function regexp match")
            End If
        Catch ex As Exception
            MsgBox("Error: " & ex.ToString)
        Finally

            'If an error occured, then need to make sure that the undo context is cleaned up.
            'Otherwise, the editor can be left in a perpetual undo context
            If oUnDo.IsOpen Then
                oUnDo.Close()
            End If

            DTE.SuppressUI = False
        End Try

    End Sub

SmartNavigation with Metabuilders Combobox

Posted on by

I ran into a little problem trying to integrate Metabuilders combobox into an asp.net web app I am creating.

The problem was that the onload event handler was not properly firing when smartNav was turned on.

The “InitScript” was as follows:

if ( typeof( window.addEventListener ) != "undefined" ) {
    window.addEventListener("load", ComboBox_Init, false);
    alert('case 1');
} else if ( typeof( window.attachEvent ) != "undefined" ) {
    window.attachEvent("onload", ComboBox_Init);
} else {
    ComboBox_Init();

}

Well when you are using smartNav, the window.onload event is only fired the first time you reach the page.  So I used this bit of C# in the control to get it to work.

String initScript = resources.GetString("InitScript");
if (this.Page.SmartNavigation)
{
    this.Page.RegisterStartupScript("MetaBuilders.WebControls.ComboBox Init with Smartnav", "<script>ComboBox_Init();</script>");
}
else
{
    this.Page.RegisterStartupScript("MetaBuilders.WebControls.ComboBox Init", initScript); 
}

 

Checking for JavaScript Variable Definitions

Posted on by

In some cases you need to be able to check if a variable has been defined, and if it has a value.

I recently had a problem where I needed a function to check if a variable had been defined, and if not, to return a default value “1”.

The following code will check if the variable is defined, and if it is, it will also check and make sure that it isn’t null, before returning the value.

 

function GetDefaultModuleId(){
    if (typeof(csDefaultModule) == "undefined"){                            
        return "1";
    }else{
        if (csDefaultModule == null){
            return "1";
        }else{
            return csDefaultModule;
        }                    
    }
}

 

Extending the Atlast AutoComplete Extender

Posted on by

I have been looking at the new “Atlas” controls, which MS has brilliantly (sarcasm) decided to rename “ASP.NET AJAX”.

The one control I have been most interested in is the autocomplete extender.

I want to use something like this, not to help populate a textox, but instead to allow the user to type a few characters in to narrow down the list of options, rather than showing them a dropdown of 10,000 items.

In otherwords, when they are done with the control, I don’t want the text in the textbox, I want the database ID value behind it, and i also don’t want to let them type in just anything they want, but rather limit their options to what is in the autocomplete options.

I found another blog post where someone is extending the autocomplete behavior:

http://aspadvice.com/blogs/garbin/archive/2006/01/02/14518.aspx

 

Performance of Web Services / Remoting / Enterprise Services

Posted on by

I had previously read and heard in presentations by Rocky Lhotka that performance comparisons between Web Services and Remoting showed that they were basically the same, and that when talking about RPC protocols ES killed them both so badly (order of magnitude) that it wasn’t worth fretting over the small diff between WS and remoting.

Rocky kinda explains this position in this post:
http://www.lhotka.net/weblog/RemotingVsWebServicesVsESCOMDCOM.aspx

However, I actually tracked down the white paper on Microsofts website:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dnwebsrv/html/asmxremotesperf.asp

Much to my suprise the giant performance improvement when using ES was only seen when calling empty functions.  In otherwords, it was basically a test of the transport.  Some “real world” tests showed ES performing faster than most other methods, but sometimes something like Remoting TCP Binary would outperform it as well.

In the tests that actually did something, the performance across the board was usually fairly comperable.  I guess this makes sense.  If you liken the round trip of an RPC call to a person going on a business trip, the speed of the airplane is less important that the time it takes the person to do the job at the end of the trip.  So even if your plane takes 3 hours instead of 2 hours, if your going to be staying for a week then that 1 hour isn’t a big deal.

The major conclusion is to not pass datasets.  Datasets are serialized as XML even if you are using the binary serializer.  I have posted some stuff on this topic as well on my blog so you can search for it if you want. 

"Updating" a SQL Inner Join Query

Posted on by

I frequently get asked how you can update a join statement in SQL.  Of course, the UPDATE syntax doesn’t allow for you do actually perform an update directly against a JOIN statement, but there are some things you can do to work around this problem.

Probably the best way is to do the update like the example below:

UPDATE Job_Opportunities
SET AwardedId = 1
WHERE JobOpportunityId = (
    SELECT JO.JobOpportunityId 
    FROM Job_Opportunities JO
    INNER JOIN
    Job_results JobResults
    ON BO.JobOpportunityID = BR.Job_id 
    AND JR.is_us = 1 
    AND JR.rank = 1 
    AND JO.JobOpportunityId = Job_Opportunities.JobOpportunityId
)

This example is updating the Job_Opportunities table, but in the WHERE clause we can use a join to make sure that the only rows that are updated are those that meet the criteria of the join.